← Back to team overview

ubuntu-touch-coreapps-reviewers team mailing list archive

Re: [Merge] lp:~ahayzen/ubuntu-clock-app/fix-1535488-autopilot-failing into lp:ubuntu-clock-app

 

Review: Needs Fixing

Code updates look good.

However, on Xenial the tests fail--I think the date picker was working, however:

Ran 5 tests in 327.505s
FAILED (failures=5)

Full log: http://paste.ubuntu.com/14573180/

Please add update the README.autopilot to include the following prereq: libhybris-utils (however even after installing this the setup couldn't set the property.)

IMO we should avoid needing sudo to run tests, but that wasn't introduced in this MP.
-- 
https://code.launchpad.net/~ahayzen/ubuntu-clock-app/fix-1535488-autopilot-failing/+merge/283021
Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app.


References