ubuntu-touch-coreapps-reviewers team mailing list archive

[Niklas Wenzel <nikwen.developer@xxxxxxxxx>]

Review: Needs Fixing

Thank you for the patch!

I really see why you want to implement this feature. However, there are some issues with the code.

What this currently does is the following: it hides the paste option when the user has selected some text and shows it if there is no selection. So currently this does not at all check if the clipboard is empty or not.
In order to change that, you would probably want to use the Clipboard API for that: https://developer.ubuntu.com/api/apps/qml/sdk-15.04.1/Ubuntu.Components.Clipboard/
It should do the trick. ;)

Cheers,
Niklas
-- 
https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/disable-paste/+merge/283244
Your team Ubuntu Terminal Developers is subscribed to branch lp:ubuntu-terminal-app.