ubuntu-touch-coreapps-reviewers team mailing list archive

[Stefano Verzegnassi <stefano92.100@xxxxxxxxx>]

Stefano Verzegnassi has proposed merging lp:~verzegnassi-stefano/ubuntu-docviewer-app/sgtileitem-keep-data into lp:ubuntu-docviewer-app.

Commit message:
SGTileItem: keep QImage data so that QSG don't fail on repainting

Requested reviews:
  Ubuntu Document Viewer Developers (ubuntu-docviewer-dev)

For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/sgtileitem-keep-data/+merge/283958

Sometimes we get some blank tile when rendering a document.
This happens only when a document is loaded for the first time: the tile gets painted with the proper texture, then it becomes blank.

I don't know much how the Qt SceneGraph works behind the scenes, but it seems that it deletes the old node of a tile when an update() is requested.
Since m_data is null when that happens, SGTileItem does not repaint the node texture as expected.
-- 
Your team Ubuntu Document Viewer Developers is requested to review the proposed merge of lp:~verzegnassi-stefano/ubuntu-docviewer-app/sgtileitem-keep-data into lp:ubuntu-docviewer-app.

=== modified file 'src/plugin/libreofficetoolkit-qml-plugin/sgtileitem.cpp'
--- src/plugin/libreofficetoolkit-qml-plugin/sgtileitem.cpp	2016-01-21 00:29:15 +0000
+++ src/plugin/libreofficetoolkit-qml-plugin/sgtileitem.cpp	2016-01-26 14:02:47 +0000
@@ -32,9 +32,6 @@
         node->setOwnsTexture(true);
         node->setRect(m_area);
 
-        // We don't need anymore QImage's data
-        m_data = QImage();
-
 #ifdef DEBUG_SHOW_TILE_BORDER
         drawTileBorders(node);
 #endif