ubuntu-touch-coreapps-reviewers team mailing list archive

[David Planella <david.planella@xxxxxxxxxx>]

David Planella has proposed merging lp:~dpm/reminders-app/fix-deb-build into lp:reminders-app.

Requested reviews:
  Jenkins Bot (ubuntu-core-apps-jenkins-bot): continuous-integration
  Ubuntu Notes app developers (notes-app-dev)
Related bugs:
  Bug #1539482 in Ubuntu Notes app: "Daily builds fail after NotesPage test failure "
  https://bugs.launchpad.net/reminders-app/+bug/1539482

For more details, see:
https://code.launchpad.net/~dpm/reminders-app/fix-deb-build/+merge/284423

Fixes the missing dependency on oxide upon build and running the tests on a daily PPA:

file:///«BUILDDIR»/reminders-app-0.4+15.04.20141118+bzr529~ubuntu15.10.1/src/app/qml/Reminders.qml:30:1: module "com.canonical.Oxide" is not installed
     import com.canonical.Oxide 1.5

Full log: https://launchpadlibrarian.net/235626941/buildlog_ubuntu-wily-i386.reminders-app_0.4+15.04.20141118+bzr529~ubuntu15.10.1_BUILDING.txt.gz

Note: for some reason I could not get the tests running on a local build. The first test just hangs - not sure if being in Xenial makes a difference, or if there was an issue with autopilot or qmltestrunner. So any help on making the tests run locally would be greatly appreciated
-- 
Your team Ubuntu Notes app developers is requested to review the proposed merge of lp:~dpm/reminders-app/fix-deb-build into lp:reminders-app.

=== modified file 'debian/control'
--- debian/control	2015-11-02 21:42:04 +0000
+++ debian/control	2016-01-29 10:53:49 +0000
@@ -7,6 +7,7 @@
                gettext,
                intltool,
                libboost-dev,
+               liboxideqt-qmlplugin,
                libssl-dev,
                pkg-config,
                python3-all,