← Back to team overview

ubuntu-touch-coreapps-reviewers team mailing list archive

Re: [Merge] lp:~mcintire-evan/ubuntu-terminal-app/improve_readmes into lp:ubuntu-terminal-app

 

Thanks a lot for the improvements!

As the person who originally wrote the READMEs, please note that on the "Formatted READMEs with MarkDown", they are already in valid markdown format.

I would suggest not changing the ## vs == header [1] formatting, as it's a subjective preference, and if we change it now for Terminal, we'll need to do the change it for all other app's for consistency's sake, which means quite a lot of extra work we could be investing in development instead :)

The same with the [Launchpad Translations][] vs [Launchpad Translations](https://translations.launchpad.net/ubuntu-terminal-app) links.

Keep up the good work!

[1] https://daringfireball.net/projects/markdown/syntax#header
-- 
https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/improve_readmes/+merge/280927
Your team Ubuntu Terminal Developers is requested to review the proposed merge of lp:~mcintire-evan/ubuntu-terminal-app/improve_readmes into lp:ubuntu-terminal-app.


References