← Back to team overview

ubuntu-touch-coreapps-reviewers team mailing list archive

Re: [Merge] lp:~mcintire-evan/ubuntu-terminal-app/auto-focus-auth into lp:ubuntu-terminal-app

 

Hi Evan!
As long as you only need to test the TextField focus, you can force the auth dialog to appear on desktop too. In AuthenticationService.qml, line 33, you can remove the 'if' condition, so that the dialog will be always shown on any platform.

http://bazaar.launchpad.net/~ubuntu-terminal-dev/ubuntu-terminal-app/reboot/view/head:/src/app/qml/AuthenticationService.qml#L33

As a side note, the auth dialog does not get the focus because of the multiple requests of 'forceActiveFocus()' during initialization, therefore the focus stays on the terminal widget. By fixing this, you will probably fix also the bug at:
  https://bugs.launchpad.net/ubuntu-terminal-app/+bug/1488481/comments/3 
-- 
https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/auto-focus-auth/+merge/284502
Your team Ubuntu Terminal Developers is requested to review the proposed merge of lp:~mcintire-evan/ubuntu-terminal-app/auto-focus-auth into lp:ubuntu-terminal-app.


References