ubuntu-touch-coreapps-reviewers team mailing list archive

[Niklas Wenzel <nikwen.developer@xxxxxxxxx>]

Niklas Wenzel has proposed merging lp:~nikwen/ubuntu-terminal-app/improve-list-item-design into lp:ubuntu-terminal-app.

Commit message:
Tweak the design of the ListItems in the settings

Requested reviews:
  Stefano Verzegnassi (verzegnassi-stefano)
  Ubuntu Terminal Developers (ubuntu-terminal-dev)

For more details, see:
https://code.launchpad.net/~nikwen/ubuntu-terminal-app/improve-list-item-design/+merge/285274

Tweak the design of the ListItems in the settings
-- 
Your team Ubuntu Terminal Developers is requested to review the proposed merge of lp:~nikwen/ubuntu-terminal-app/improve-list-item-design into lp:ubuntu-terminal-app.

=== modified file 'src/app/qml/ColorSchemePage.qml'
--- src/app/qml/ColorSchemePage.qml	2016-01-22 18:29:56 +0000
+++ src/app/qml/ColorSchemePage.qml	2016-02-06 17:00:20 +0000
@@ -32,7 +32,7 @@
         model: settings.profilesList
         delegate: ListItem {
             ListItemLayout {
-                anchors.fill: parent
+                anchors.verticalCenter: parent.verticalCenter
                 title.text: modelData
 
                 Icon {

=== modified file 'src/app/qml/SettingsPage.qml'
--- src/app/qml/SettingsPage.qml	2016-01-22 18:37:29 +0000
+++ src/app/qml/SettingsPage.qml	2016-02-06 17:00:20 +0000
@@ -34,16 +34,16 @@
         Column {
             id: mainColumn
             anchors { left: parent.left; right: parent.right }
-            spacing: units.gu(1)
 
             ListItem {
                 ListItemLayout {
-                    anchors.fill: parent
+                    anchors.verticalCenter: parent.verticalCenter
                     title.text: i18n.tr("Layouts")
 
                     Icon {
                         SlotsLayout.position: SlotsLayout.Trailing
-                        width: units.gu(2); height: width
+                        width: units.gu(2)
+                        height: width
                         name: "go-next"
                     }
                 }
@@ -84,10 +84,15 @@
             }
 
             ListItem {
-                height: units.gu(12)
+                height: units.gu(13)
 
                 Label {
-                    anchors { left: parent.left; margins: units.gu(2) }
+                    anchors {
+                        top: parent.top
+                        left: parent.left
+                        right: parent.right
+                        margins: units.gu(2)
+                    }
                     text: i18n.tr("Font Size:")
                 }