ubuntu-touch-coreapps-reviewers team mailing list archive

[Stefano Verzegnassi <stefano92.100@xxxxxxxxx>]

> As Stefano said[1], I do think we should avoid adding too much to the C++ code. Whenever we end
> up redoing the clipboard stuff we could maybe remove this and the isClipboardEmpty() functions?

I think we can keep them as long as they are pure Qt implementations.
I had a further look at the usage of Ubuntu.Components.Clipboard, in particular for uri type, which seems to be handled differently in Gnome Terminal.

e.g.
1) Open Nautilus
2) Choose a file from your home and copy it (Ctrl+C)
3) Open gnome-terminal and paste (Ctrl+Alt+V)
   RESULT: the object is pasted as "file:///home/<username>/<file_name+ext>"
4) Do the same with ubuntu-terminal-app
   RESULT: the object is pasted as "/home/<username>/<file_name+ext>"

Fortunately, the Ubuntu UITK implementation is just a wrapper around QClipboard, which is already used in QmlTermWidget, so we can go on with a pure Qt/C++ implementation with no many changes.

A different case is the drop of a file into the terminal window, which is something ubuntu-terminal-app does not handle yet.

This could be done through QML, although it would be better to do via C++, since all the mouse/keyb events are currently handled by the terminal widget itself.
In this case we would end up with a bigger change to the source code.

> There are a few bugs relating to improving the clipboard experience, maybe we could make a
> blueprint or something to organize all that and how we want to redo it?

Blueprints + bugs sounds as a good plan.

I believe we should review the code of the terminal plugin. I had a look some week ago, and only the console has been ported from QWidget to QtQuick (e.g. see the search functionalities, still QWidget-based).

As we have a list of things we need to improve, we can start planning the changes to the C++ sources, being sure we won't break the compatibility with QTermWidget or cool-retro-term.

I will try to get in touch with Filippo, since he's the author of the porting.

It could be useful to discuss of this somewhere else.
I know Niklas is quite busy in this period, and restoring the weekly meeting could be complicated.
What about moving our discussion on mails?
-- 
https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/disable-copy/+merge/285287
Your team Ubuntu Terminal Developers is requested to review the proposed merge of lp:~mcintire-evan/ubuntu-terminal-app/disable-copy into lp:ubuntu-terminal-app.