ubuntu-touch-coreapps-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~mcintire-evan/ubuntu-terminal-app/disable-copy into lp:ubuntu-terminal-app

To: Evan McIntire <mcintire.evan@xxxxxxxxx>
From: Niklas Wenzel <nikwen.developer@xxxxxxxxx>
Date: Mon, 08 Feb 2016 17:22:02 -0000
In-reply-to: <20160207073532.28379.7138.launchpad@ackee.canonical.com>
Reply-to: mp+285287@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

Thank you for the patch! The code looks good to me and I assume Stefano tested it already.

However, I'm sorry that I am _that_ guy again. :p

For comments we usually put a whitespace after the two leading slashes. Additionally, we only put semi-colons after QML properties when there are two in the same line.

Again, sorry for that, but I think it makes sense to agree on a common code style. Nevertheless, good work! :)
-- 
https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/disable-copy/+merge/285287
Your team Ubuntu Terminal Developers is subscribed to branch lp:ubuntu-terminal-app.

References

[Merge] lp:~mcintire-evan/ubuntu-terminal-app/disable-copy into lp:ubuntu-terminal-app
From: Evan McIntire, 2016-02-07