ubuntu-touch-coreapps-reviewers team mailing list archive

[Stefano Verzegnassi <stefano92.100@xxxxxxxxx>]

Review: Needs Fixing

Sorry Evan for being that hateful guy, but the branch surely needs a fix. :)

Line 9 of the diff should be:
_X-Ubuntu-Splash-Title=Terminal

Note the underscore before "X-Ubuntu-Splash-Title". That way "Terminal" can be properly translated into user's language.


As for the rest, I'm not sure if we really want to show an header since we don't have any header in the main page of terminal-app.
This is anyway not a important question, so feel free to choose the design you prefer :)
-- 
https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/splash-screen/+merge/285673
Your team Ubuntu Terminal Developers is subscribed to branch lp:ubuntu-terminal-app.