ubuntu-touch-coreapps-reviewers team mailing list archive

[Stefano Verzegnassi <stefano92.100@xxxxxxxxx>]

Stefano Verzegnassi has proposed merging lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-pdfview-be-visibility into lp:ubuntu-docviewer-app.

Commit message:
[PdfView] Disable bottom edge gesture if the current document does not provide any ToC

Requested reviews:
  Ubuntu Document Viewer Developers (ubuntu-docviewer-dev)
Related bugs:
  Bug #1546164 in Ubuntu Document Viewer App: "[pdfView] Bottom edge is still visible and active when the document has no ToC"
  https://bugs.launchpad.net/ubuntu-docviewer-app/+bug/1546164

For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/fix-pdfview-be-visibility/+merge/286193
-- 
Your team Ubuntu Document Viewer Developers is requested to review the proposed merge of lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-pdfview-be-visibility into lp:ubuntu-docviewer-app.

=== modified file 'src/app/qml/pdfView/PdfView.qml'
--- src/app/qml/pdfView/PdfView.qml	2016-02-03 13:51:11 +0000
+++ src/app/qml/pdfView/PdfView.qml	2016-02-16 15:57:49 +0000
@@ -155,6 +155,9 @@
                 onTriggered: contentsBottomEdge.commit()
             }
             flickable: pdfPage.flickable
+
+            visible: contentsBottomEdge.visible
+            enabled: contentsBottomEdge.enabled
         }
 
         contentComponent: Item {
@@ -164,6 +167,7 @@
         }
 
         enabled: poppler.tocModel.count > 0
+        visible: enabled
 
         onCollapseCompleted: {
             _realPage = contentsPage.createObject(null)