ubuntu-touch-coreapps-reviewers team mailing list archive

[Victor Thompson <victor.thompson@xxxxxxxxx>]

Victor Thompson has proposed merging lp:~vthompson/music-app/ix-1538832-gridview-offset into lp:music-app.

Commit message:
* Remove offset from the top of AddToPlaylist.qml

Requested reviews:
  Music App Developers (music-app-dev)
Related bugs:
  Bug #1538832 in Ubuntu Music App: "The "Select playlist" page has a large offset between the header and the start of the GridView"
  https://bugs.launchpad.net/music-app/+bug/1538832

For more details, see:
https://code.launchpad.net/~vthompson/music-app/ix-1538832-gridview-offset/+merge/287400

* Remove offset from the top of AddToPlaylist.qml
-- 
Your team Music App Developers is requested to review the proposed merge of lp:~vthompson/music-app/ix-1538832-gridview-offset into lp:music-app.

=== modified file 'app/ui/AddToPlaylist.qml'
--- app/ui/AddToPlaylist.qml	2016-01-29 02:20:55 +0000
+++ app/ui/AddToPlaylist.qml	2016-02-28 01:37:13 +0000
@@ -61,7 +61,8 @@
     anchors {
         fill: undefined
     }
-    height: mainView.height
+
+    height: mainView.height + musicToolbar.height
     width: mainView.width
 
     property var chosenElements: []

=== modified file 'debian/changelog'
--- debian/changelog	2016-02-26 03:18:20 +0000
+++ debian/changelog	2016-02-28 01:37:13 +0000
@@ -6,6 +6,7 @@
   * Change translation strings from song to track (LP: #1378143).
   * Ensure that only one ContentHubExport page is open (LP: #1538863).
   * Fix fallback image path in MusicListItem (LP: #1549580).
+  * Remove offset from the top of AddToPlaylist.qml (LP: #1538832).
 
   [ Andrew Hayzen ]
   * Fix so that a press and hold cannot disable selection in the ContentHubExport.qml (LP: #1538838)