ubuntu-touch-coreapps-reviewers team mailing list archive

[Evan McIntire <mcintire.evan@xxxxxxxxx>]

Added another reply - we're getting so close here!

Diff comments:

> 
> === modified file 'src/app/qml/ubuntu-terminal-app.qml'
> --- src/app/qml/ubuntu-terminal-app.qml	2016-02-07 18:24:56 +0000
> +++ src/app/qml/ubuntu-terminal-app.qml	2016-02-13 21:25:20 +0000
> @@ -12,8 +12,8 @@
>      applicationName: "com.ubuntu.terminal"
>      automaticOrientation: true
>  
> -    width: units.gu(90)
> -    height: units.gu(55)
> +    width: 40 * settings.fontPixelSize()

Thanks for the info! I've played around a bit with the values, and I have something that works, but I'm not sure how it'll work with other sizes, so I'd like your know your opinion on it

width = 81 * terminalPage.terminal.fontMetrics.width
height = 25 * terminalPage.terminal.fontMetrics.height

For some reason, this is what works to get 80 columns and 24 rows. Based on the numbers, I can see why, but this just feels pretty hacky and wrong to me. Any ideas? (BTW, the fontMetrics object is of type QSize( https://doc.qt.io/qt-5/qsize.html ))

> +    height: 24 * settings.fontPixelSize()
>  
>      AuthenticationService {
>          onDenied: Qt.quit();


-- 
https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/window-font-size/+merge/285285
Your team Ubuntu Terminal Developers is subscribed to branch lp:ubuntu-terminal-app.