ubuntu-touch-coreapps-reviewers team mailing list archive

[Nicholas Skaggs <nskaggs@xxxxxxxxxx>]

Nicholas Skaggs has proposed merging lp:~nskaggs/reminders-app/add-jenkins-info into lp:reminders-app.

Commit message:
add jenkins info, add mp readme

Requested reviews:
  Ubuntu Notes app developers (notes-app-dev)

For more details, see:
https://code.launchpad.net/~nskaggs/reminders-app/add-jenkins-info/+merge/288161

add jenkins info, add mp readme
-- 
Your team Ubuntu Notes app developers is requested to review the proposed merge of lp:~nskaggs/reminders-app/add-jenkins-info into lp:reminders-app.

=== added file 'README.Mergeproposal.md'
--- README.Mergeproposal.md	1970-01-01 00:00:00 +0000
+++ README.Mergeproposal.md	2016-03-04 20:00:32 +0000
@@ -0,0 +1,32 @@
+Prerequisites to approving a Merge Proposal (MP)
+================================================
+
+Over time, it has been found that insufficient testing by reviewers sometimes leads to reminders trunk not buildable in Qtcreator due to manifest errors, or translation pot file not updated. As such, please follow the checklist below before top-approving a MP.
+
+Checklist
+=========
+
+*   Does the MP add/remove user visible strings? If Yes, has the pot file been
+    updated?
+
+*   Does the MP change the UI? If Yes, has it been approved by design?
+
+*   Did you perform an exploratory manual test run of your code change and any
+    related functionality?
+
+*   If the MP fixes a bug or implements a feature, are there accompanying unit
+    and autopilot tests?
+
+*   Is the reminders trunk buildable and runnable using Qtcreator?
+
+*   Was the debian changelog updated?
+
+*   Was the copyright years updated if necessary?
+
+The above checklist is more of a guideline to help reminders trunk stay buildable,
+stable and up to date.
+
+
+Jenkins
+=======
+In addition to manual reviews, merge proposals are subject to being run in jenkins to ensure the application builds and any unit tests are successful. For more information on jenkins and how it works, see the [Core Apps Jenkins Wiki](https://wiki.ubuntu.com/Touch/CoreApps/Jenkins)