ubuntu-touch-coreapps-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~mcintire-evan/ubuntu-terminal-app/window-font-size into lp:ubuntu-terminal-app

To: Evan McIntire <mcintire.evan@xxxxxxxxx>
From: Stefano Verzegnassi <stefano92.100@xxxxxxxxx>
Date: Sat, 05 Mar 2016 00:32:33 -0000
In-reply-to: <20160213212621.11706.51320.launchpad@ackee.canonical.com>
Reply-to: mp+285285@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

I guess you decided to set the values from the 'Component.onCompleted' event in order to prevent the window size from being updated after a change of the font size.

That's okay to me, it's the Konsole behaviour we discussed earlier.

Looks good to me! Thanks Evan!


 
-- 
https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/window-font-size/+merge/285285
Your team Ubuntu Terminal Developers is subscribed to branch lp:ubuntu-terminal-app.

References

[Merge] lp:~mcintire-evan/ubuntu-terminal-app/window-font-size into lp:ubuntu-terminal-app
From: Evan McIntire, 2016-02-13