← Back to team overview

ubuntu-touch-coreapps-reviewers team mailing list archive

[Merge] lp:~renatofilho/ubuntu-calendar-app/fix-arale-event-minimum-size into lp:ubuntu-calendar-app

 

Renato Araujo Oliveira Filho has proposed merging lp:~renatofilho/ubuntu-calendar-app/fix-arale-event-minimum-size into lp:ubuntu-calendar-app.

Commit message:
avoid events to be draw too small, the minimumHeight will be 30 min

Requested reviews:
  Jenkins Bot (ubuntu-core-apps-jenkins-bot): continuous-integration
  Ubuntu Calendar Developers (ubuntu-calendar-dev)

For more details, see:
https://code.launchpad.net/~renatofilho/ubuntu-calendar-app/fix-arale-event-minimum-size/+merge/288333
-- 
Your team Ubuntu Calendar Developers is requested to review the proposed merge of lp:~renatofilho/ubuntu-calendar-app/fix-arale-event-minimum-size into lp:ubuntu-calendar-app.
=== modified file 'EventBubble.qml'
--- EventBubble.qml	2016-03-05 03:04:53 +0000
+++ EventBubble.qml	2016-03-07 18:49:59 +0000
@@ -131,7 +131,8 @@
         width = parent ? parent.width * sizeOfRow : 0
         x = depthInRow * width
         z = depthInRow
-        height = Math.max(30, (durationInMinutes * parent.minuteHeight))
+        // avoid events to be draw too small, the minimumHeight will be 30 min
+        height = Math.max(30, durationInMinutes) * parent.minuteHeight
     }
 
     onEventChanged: {


References