ubuntu-touch-coreapps-reviewers team mailing list archive

[Stefano Verzegnassi <stefano92.100@xxxxxxxxx>]

Review: Needs Information

Tested on my PC and it works well.
My only question is about Python coding style: should we still refer to the pep8 conventions?

PS. One diff comment included (i.e. music-app typo).


======

$ pep8 ./tests
./tests/autopilot/ubuntu_terminal_app/tests/__init__.py:42:80: E501 line too long (94 > 79 characters)
./tests/autopilot/ubuntu_terminal_app/tests/__init__.py:45:80: E501 line too long (90 > 79 characters)
./tests/autopilot/ubuntu_terminal_app/tests/__init__.py:47:80: E501 line too long (89 > 79 characters)
./tests/autopilot/ubuntu_terminal_app/tests/__init__.py:72:80: E501 line too long (80 > 79 characters)
./tests/autopilot/ubuntu_terminal_app/tests/__init__.py:90:5: E303 too many blank lines (2)

Diff comments:

> === added file 'README.autopilot.md'
> --- README.autopilot.md	1970-01-01 00:00:00 +0000
> +++ README.autopilot.md	2016-03-07 22:19:53 +0000
> @@ -0,0 +1,74 @@
> +Running Autopilot tests
> +=======================
> +If you are looking for more info about Autopilot or writing AP tests, here are some useful links to help you:
> +
> +- [Ubuntu - Quality](http://developer.ubuntu.com/start/quality)
> +- [Autopilot - Python](https://developer.ubuntu.com/api/autopilot/python/1.5.0/)
> +
> +For help and options on running tests, see:
> +
> +- [Autopilot tests](https://developer.ubuntu.com/en/start/platform/guides/running-autopilot-tests/)
> +
> +Prerequisites
> +=============
> +
> +Install the following autopilot packages required to run the tests,
> +
> +    $ sudo apt-get install python3-autopilot libautopilot-qt ubuntu-ui-toolkit-autopilot python3-autopilot-vis
> +
> +Running tests on the desktop
> +============================
> +
> +Using terminal:
> +
> +*  Branch the code
> +
> +    $ bzr branch lp:ubuntu-terminal-app
> +
> +*  Navigate to the tests/autopilot directory.
> +
> +    $ cd tests/autopilot
> +
> +*  run all tests.
> +
> +    $ autopilot3 run -vv ubuntu_terminal_app
> +
> +* to list all tests:
> +
> +    $ autopilot3 list ubuntu_terminal_app
> +
> + To run only one test
> +
> +    $ autopilot3 run -vv ubuntu_terminal_app.tests.test_name
> +
> +* Debugging tests using autopilot vis
> +
> +    $ autopilot3 launch -i Qt qmlscene src/app/terminal
> +
> +    $ autopilot3 vis
> +
> +Running tests using Ubuntu SDK
> +==============================
> +
> +Refer this [tutorial](https://developer.ubuntu.com/en/start/platform/guides/running-autopilot-tests/) to run tests on Ubuntu SDK:
> +
> +Running tests on device or emulator:
> +====================================
> +
> +Using autopkg:
> +
> +*  Branch the Music app code, for example,

You've missed a further reference a music-app

> +
> +    $ bzr branch lp:ubuntu-terminal-app
> +
> +*  Navigate to the source directory.
> +
> +    $ cd ubuntu-terminal-app
> +
> +*  Build a click package
> +
> +    $ click-buddy .
> +
> +*  Run the tests on device (assumes only one click package in the directory)
> +
> +    $ adt-run . *.click --- ssh -s adb -- -p <PASSWORD>
> \ No newline at end of file


-- 
https://code.launchpad.net/~nskaggs/ubuntu-terminal-app/restore-autopilot/+merge/288347
Your team Ubuntu Terminal Developers is subscribed to branch lp:ubuntu-terminal-app.