← Back to team overview

ubuntu-touch-coreapps-reviewers team mailing list archive

[Merge] lp:~nskaggs/ubuntu-docviewer-app/create-cache into lp:ubuntu-docviewer-app

 

Nicholas Skaggs has proposed merging lp:~nskaggs/ubuntu-docviewer-app/create-cache into lp:ubuntu-docviewer-app with lp:~nskaggs/ubuntu-docviewer-app/restore-ap-template as a prerequisite.

Commit message:
Create cache folder during cmake copy

Requested reviews:
  Ubuntu Document Viewer Developers (ubuntu-docviewer-dev)

For more details, see:
https://code.launchpad.net/~nskaggs/ubuntu-docviewer-app/create-cache/+merge/288718

Create cache folder during cmake copy
-- 
Your team Ubuntu Document Viewer Developers is requested to review the proposed merge of lp:~nskaggs/ubuntu-docviewer-app/create-cache into lp:ubuntu-docviewer-app.
=== modified file 'cmake/modules/Click.cmake'
--- cmake/modules/Click.cmake	2016-02-22 22:44:48 +0000
+++ cmake/modules/Click.cmake	2016-03-10 22:26:53 +0000
@@ -17,7 +17,7 @@
   set(CUSTOM_SCRIPT ${CMAKE_CURRENT_SOURCE_DIR}/click/disable-lo-features.sh)
   set(UPSTREAM_LIBS_DIR ${CMAKE_BINARY_DIR}/upstream-libs)
 
-  MESSAGE("Grabbing upstream libs to ${UPSTREAM_LIBS_DIR}") 
+  MESSAGE("Grabbing upstream libs to ${UPSTREAM_LIBS_DIR}")
 
   if(NO_CACHE)
     # It has been specified not to cache .click dependencies on the machine.
@@ -39,6 +39,7 @@
     else()
       MESSAGE("Cache miss, downloading from network.")
       execute_process(
+        COMMAND mkdir ${UPSTREAM_CACHE}
         COMMAND mkdir ${UPSTREAM_LIBS_DIR}
         COMMAND ${GET_CLICK_DEPS_TOOL} -d ${DEPS_MANIFEST} -c ${CUSTOM_SCRIPT} ${CLICK_ARCH} ${UPSTREAM_LIBS_DIR}
       )


Follow ups