ubuntu-touch-coreapps-reviewers team mailing list archive

[Andrew Hayzen <ahayzen@xxxxxxxxx>]

Review: Approve

Interesting fix, but seems to work :-)

Diff comments:

> === modified file 'app/components/CoverGrid.qml'
> --- app/components/CoverGrid.qml	2015-08-12 23:36:44 +0000
> +++ app/components/CoverGrid.qml	2016-03-13 21:58:36 +0000
> @@ -73,8 +76,17 @@
>  
>                  onStatusChanged: {
>                      if (status === Image.Error) {
> -                        source = Qt.resolvedUrl("../graphics/music-app-cover@xxxxxx")
> -                    } else if (status === Image.Ready && index === 0) {
> +                        useFallbackArt = true
> +
> +                        // If this coverGrid is set to the Player's currentMeta,
> +                        // then override the player's flag to show the fallback art
> +                        if (coverGrid.covers[index].useFallbackArt !== undefined)

We have usually kept the opening curly brace on the same line so
if (condition) {
  ...
}

> +                        {
> +                            coverGrid.covers[index].useFallbackArt = true
> +                        }
> +                    }
> +
> +                    if (status === Image.Ready && index === 0) {
>                          firstSource = source
>                      }
>                  }


-- 
https://code.launchpad.net/~vthompson/music-app/fix-1549557/+merge/288871
Your team Music App Developers is subscribed to branch lp:music-app.