ubuntu-touch-coreapps-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~majster-pl/ubuntu-calendar-app/new-event-page into lp:ubuntu-calendar-app

To: mp+288637@xxxxxxxxxxxxxxxxxx
From: Nekhelesh Ramananthan <krnekhelesh@xxxxxxxxx>
Date: Tue, 15 Mar 2016 11:26:58 -0000
In-reply-to: <20160310132010.6454.17282.launchpad@ackee.canonical.com>
Reply-to: mp+288637@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

Nice work! It is *almost* ready. Just few minor touch ups to do and then we are set to land this MP.

1. In the old guest design layout, I notice 3 minor issues ( refer to http://imgur.com/HC4JAcs )

a) Remove the listitem dividers of the guests listitem
b) set the guest listitem height as listitemlayout.height. Otherwise it is not centered vertically.
c) Align the guest names to the "Add Guest" button. This can be done by setting the left and right margin to -2 gu. Yes negative :)

2. In the repeat and reminders page, the "Repeat" and "Reminder" listitem header is shown using "blue" color due to the new SDK. Please change these to the new list items to fix this issue.
( refer to http://imgur.com/5yzzm8h )

3. The selection color which is shown when you click on the date/time is a bit strong. Please change the background to lightgray shade and the text color to white/black. 
-- 
https://code.launchpad.net/~majster-pl/ubuntu-calendar-app/new-event-page/+merge/288637
Your team Ubuntu Calendar Developers is subscribed to branch lp:ubuntu-calendar-app.