← Back to team overview

ubuntu-touch-coreapps-reviewers team mailing list archive

Re: [Merge] lp:~artmello/ubuntu-calendar-app/ubuntu-calendar-app-fix_1373945 into lp:ubuntu-calendar-app

 

just one small change

Diff comments:

> 
> === modified file 'EventListModel.qml'
> --- EventListModel.qml	2016-03-04 16:10:56 +0000
> +++ EventListModel.qml	2016-03-14 22:21:27 +0000
> @@ -110,9 +124,9 @@
>          var cals = getCollections();
>           for(var i = 0 ; i < cals.length ; ++i) {
>               var cal = cals[i]
> -             cal.setExtendedMetaData("X-CAL-DEFAULT-CALENDAR", false);
>               if( cal.collectionId === collectionId) {
> -                cal.setExtendedMetaData("X-CAL-DEFAULT-CALENDAR", true);
> +                 cal.setExtendedMetaData("collection-default", true);
> +                 eventModel.saveCollection(cal);

we can have a return here.

>               }
>          }
>      }


-- 
https://code.launchpad.net/~artmello/ubuntu-calendar-app/ubuntu-calendar-app-fix_1373945/+merge/288988
Your team Ubuntu Calendar Developers is requested to review the proposed merge of lp:~artmello/ubuntu-calendar-app/ubuntu-calendar-app-fix_1373945 into lp:ubuntu-calendar-app.


References