← Back to team overview

ubuntu-touch-coreapps-reviewers team mailing list archive

[Merge] lp:~verzegnassi-stefano/ubuntu-terminal-app/fix-1559892 into lp:ubuntu-terminal-app

 

Stefano Verzegnassi has proposed merging lp:~verzegnassi-stefano/ubuntu-terminal-app/fix-1559892 into lp:ubuntu-terminal-app.

Commit message:
Added missing 'NotifyDialog.qml' file, so that app can properly notify whether a wrong password has been typed during PAM auth

Requested reviews:
  Ubuntu Terminal Developers (ubuntu-terminal-dev)
Related bugs:
  Bug #1559892 in Ubuntu Terminal App: "No indication of an error when an incorrect passcode is entered"
  https://bugs.launchpad.net/ubuntu-terminal-app/+bug/1559892

For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-terminal-app/fix-1559892/+merge/290129

Added missing 'NotifyDialog.qml' file, so that app can properly notify whether a wrong password has been typed during PAM auth
-- 
Your team Ubuntu Terminal Developers is requested to review the proposed merge of lp:~verzegnassi-stefano/ubuntu-terminal-app/fix-1559892 into lp:ubuntu-terminal-app.
=== added file 'src/app/qml/NotifyDialog.qml'
--- src/app/qml/NotifyDialog.qml	1970-01-01 00:00:00 +0000
+++ src/app/qml/NotifyDialog.qml	2016-03-25 17:34:25 +0000
@@ -0,0 +1,30 @@
+/*
+ * Copyright (C) 2013 Canonical Ltd
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 3 as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ * Authored by: Arto Jalkanen <ajalkane@xxxxxxxxx>
+ */
+import QtQuick 2.4
+import Ubuntu.Components 1.3
+import Ubuntu.Components.Popups 1.3
+
+Dialog {
+    id: root
+    Button {
+        text: i18n.tr("Ok")
+        onClicked: {
+            PopupUtils.close(root)
+        }
+    }
+}


Follow ups