ubuntu-touch-coreapps-reviewers team mailing list archive

[Stefano Verzegnassi <stefano92.100@xxxxxxxxx>]

Hey Roman, I can think at three alternatives:

1) Set MainView.backgroundColor according to the nightMode status.

MainView {
    backgroundColor: nightModeEnabled ? "black" : "white"
}

I'm almost sure you'll also have to disable auto-theming (i.e. UITK
switches the app theme between Ambiance and SuruDark according to the
set background color).

2) Add a QML Rectangle to the MainView, in order to restore the previous
code. Anyway, you'll lose the performance boost mentioned in the bug
report above.

MainView {
    id: root

    Rectangle {
        anchors.fill: parent
        color: root.backgroundColor
    }
}

3) Don't use a shader on the whole view, but use individual shaders on
each QML Image (if required). Set the app theme according to the current
mode.

MainView {
    property bool nightModeEnabled: true

    theme.name: nightModeEnabled ? "Ubuntu.Components.Themes.SuruDark" :
"Ubuntu.Components.Themes.Ambiance"

    ArticleItem {
        Image {
            [...]

            layer.enabled: nightModeEnabled
            layer.item: NightModeShader {}
        }
    }
}      
    


I'd probably choose 2), which is faster to implement and safer (i.e. less unexpected issues - that's how it used to work until now).
This is something we should fix in DocViewer too, but I'd probably move to a different solution (the first one) in a longer term.

I guess the shader usage (currently it's used only in DocViewer and Shorts) hasn't been considered by the SDK team when they did that change. So yes, we should fix it.
However, it could be worth to ask them which solution they would suggest (and eventually suggest a similar feature for the next UITK release).

-- 
You received this bug notification because you are a member of Ubuntu
Shorts Developers, which is subscribed to Ubuntu Shorts App.
Matching subscriptions: Ubuntu RSS Reader Bugmail
https://bugs.launchpad.net/bugs/1559724

Title:
  [shorts] If night mode is enabled, the app background is still white

Status in Ubuntu Shorts App:
  Confirmed

Bug description:
  I think this is due to the new palette in the SDK landing in rc-
  proposed. The app background is white, which defeats the purpose of
  night mode. Also, articles are impossible to read for this reason.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-rssreader-app/+bug/1559724/+subscriptions