ubuntu-touch-coreapps-reviewers team mailing list archive

[Renato Araujo Oliveira Filho <renato.filho@xxxxxxxxxxxxx>]

works nice. But I have some inline questions.

Diff comments:

> === modified file 'MonthComponent.qml'
> --- MonthComponent.qml	2016-03-09 01:35:28 +0000
> +++ MonthComponent.qml	2016-03-24 13:03:37 +0000
> @@ -245,19 +250,14 @@
>              var dayItem = getItemAt(mouse.x, mouse.y)
>  
>              if( dayItem.isSelected ) {
> -                var selectedDate = new Date();
> -                selectedDate.setFullYear(intern.monthStartYear)
> -                selectedDate.setMonth(intern.monthStartMonth + 1)
> -                selectedDate.setDate(dayItem.date)
> +                var selectedDate = new Date(dayItem.delegateDate.getTime());

Is this change intentional? The idea of the old code was to create the event on the current time.

>                  selectedDate.setMinutes(60, 0, 0)
>                  pageStack.push(Qt.resolvedUrl("NewEvent.qml"), {"date":selectedDate, "model":eventModel});
>              }
>          }
>          onClicked: {
>              var dayItem = getItemAt(mouse.x, mouse.y)
> -            var selectedDate = new Date(intern.monthStartYear,
> -                                        intern.monthStartMonth + 1,
> -                                        dayItem.date, 0, 0, 0, 0)
> +            var selectedDate = new Date(dayItem.delegateDate.getTime());

Is this change intentional? The idea of the old code was to create the event on the current time.

>              if (root.isYearView) {
>                  //If yearView is clicked then open selected MonthView
>                  root.monthSelected(selectedDate);


-- 
https://code.launchpad.net/~artmello/ubuntu-calendar-app/ubuntu-calendar-app-fix_1539982/+merge/290035
Your team Ubuntu Calendar Developers is subscribed to branch lp:ubuntu-calendar-app.