← Back to team overview

ubuntu-touch-coreapps-reviewers team mailing list archive

Re: [Merge] lp:~artmello/ubuntu-calendar-app/ubuntu-calendar-app-fix_1508440 into lp:ubuntu-calendar-app

 


Diff comments:

> === modified file 'EventBubble.qml'
> --- EventBubble.qml	2016-03-22 20:14:49 +0000
> +++ EventBubble.qml	2016-03-24 21:40:37 +0000
> @@ -38,6 +38,7 @@
>      property Flickable flickable;
>      property bool isEventBubble: true
>      property real minimumHeight: units.gu(4)
> +    property bool strikeoutTitle: false

is possible to make a alias instead a new property?

>  
>      readonly property bool isSingleLine: (infoBubble.height < (minimumHeight * 2))
>      readonly property real startTimeInMinutes: event ? CanlendarCanvas.minutesSince(infoBubble.anchorDate, event.startDateTime) : 0.0


-- 
https://code.launchpad.net/~artmello/ubuntu-calendar-app/ubuntu-calendar-app-fix_1508440/+merge/290091
Your team Ubuntu Calendar Developers is requested to review the proposed merge of lp:~artmello/ubuntu-calendar-app/ubuntu-calendar-app-fix_1508440 into lp:ubuntu-calendar-app.


References