ubuntu-touch-coreapps-reviewers team mailing list archive

[Arthur Mello <arthur.mello@xxxxxxxxxxxxx>]

Review: Needs Fixing

in line comment

Diff comments:

> === modified file 'NewEvent.qml'
> --- NewEvent.qml	2016-03-23 18:53:48 +0000
> +++ NewEvent.qml	2016-03-28 17:56:57 +0000
> @@ -35,18 +36,22 @@
>  
>      property var date;
>      property alias allDay: allDayEventCheckbox.checked
> +    property int eventSize: -1
>  
>      property var event:null;
>      property var rule :null;
>      property var model:null;
>  
> -    property var startDate;
> -    property var endDate;
> +    property alias startDate: startDateTimeInput.dateTime
> +    property alias endDate: endDateTimeInput.dateTime
>      property alias reminderValue: eventReminder.reminderValue
>  
>      property alias scrollY: flickable.contentY
>      property bool isEdit: false
>  
> +    readonly property int millisecsInADay: 86400000
> +    readonly property int millisecsInAHour: 3600000

Typo here, should be millisecsAnHour

> +
>      signal eventAdded(var event);
>      signal eventDeleted(var event);
>      signal canceled()


-- 
https://code.launchpad.net/~renatofilho/ubuntu-calendar-app/keep-event-size/+merge/289288
Your team Ubuntu Calendar Developers is subscribed to branch lp:ubuntu-calendar-app.