ubuntu-touch-coreapps-reviewers team mailing list archive

[Stefano Verzegnassi <stefano92.100@xxxxxxxxx>]

Stefano Verzegnassi has proposed merging lp:~verzegnassi-stefano/ubuntu-docviewer-app/release-2.1.2 into lp:ubuntu-docviewer-app.

Commit message:
* Bumped framework to 15.04.4
* Fixed broken night mode (i.e. app background is still white when the mode is enabled)
* Updated changelog

Requested reviews:
  Ubuntu Document Viewer Developers (ubuntu-docviewer-dev)

For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/release-2.1.2/+merge/290962

* Bumped framework to 15.04.4
* Fixed broken night mode (i.e. app background is still white when the mode is enabled)
* Updated changelog
-- 
Your team Ubuntu Document Viewer Developers is requested to review the proposed merge of lp:~verzegnassi-stefano/ubuntu-docviewer-app/release-2.1.2 into lp:ubuntu-docviewer-app.

=== modified file 'click/manifest.json.in'
--- click/manifest.json.in	2016-02-11 18:03:07 +0000
+++ click/manifest.json.in	2016-04-05 09:34:25 +0000
@@ -2,7 +2,7 @@
     "name": "com.ubuntu.docviewer",
     "title": "Document Viewer",
     "description": "Document Viewer application for Ubuntu devices",
-    "framework": "ubuntu-sdk-15.04.3",
+    "framework": "ubuntu-sdk-15.04.4",
     "architecture": "@CLICK_ARCH@",
     "icon": "@ICON@",
     "hooks": {

=== modified file 'debian/changelog'
--- debian/changelog	2016-02-11 18:03:07 +0000
+++ debian/changelog	2016-04-05 09:34:25 +0000
@@ -1,5 +1,7 @@
 ubuntu-docviewer-app (2.1) vivid; urgency=medium
 
+  * Fixed an issue with the documents list not updating the model entries (LP: #1483218)
+  * New theming/UI components in OTA-10 fully supported (LP: #1551259)
   * LibreOffice viewer: added support for spreadsheet documents with multiple sheets (LP: #1537755)
   * LibreOffice viewer: limited zoom value to a minimum/maximum value (LP: #1501424)
   * LibreOffice viewer: added a double-tap-to-zoom gesture (LP: #1541582)

=== modified file 'src/app/qml/ubuntu-docviewer-app.qml'
--- src/app/qml/ubuntu-docviewer-app.qml	2016-03-31 17:41:13 +0000
+++ src/app/qml/ubuntu-docviewer-app.qml	2016-04-05 09:34:25 +0000
@@ -180,6 +180,15 @@
         filter.property: "name"
     }
 
+    // WORKAROUND: mainView backgroundColor is an alias for the window color, and does not
+    // refer to a child QML Rectangle anymore. This breaks our night mode shader; for that
+    // reason we need to re-add that QML Rectangle.
+    Rectangle {
+        anchors.fill: parent
+        color: mainView.backgroundColor
+        visible: nightModeEnabled
+    }
+
     PageStack {
         id: pageStack
     }