ubuntu-touch-coreapps-reviewers team mailing list archive

[Stefano Verzegnassi <stefano92.100@xxxxxxxxx>]

Review: Needs Fixing

As to the colors, everything is okay except for a typo (see the diff comment).

Sidebar color is not set and it's shown as white, when "#f7f7f7" (porcelain) should be used instead.

Diff comments:

> 
> === modified file 'src/app/qml/components/PlacesSidebar.qml'
> --- src/app/qml/components/PlacesSidebar.qml	2016-02-02 00:35:27 +0000
> +++ src/app/qml/components/PlacesSidebar.qml	2016-04-06 16:06:20 +0000
> @@ -25,7 +25,7 @@
>      id: root
>  
>      //color: Qt.rgba(0.5,0.5,0.5,0.3)
> -    color: "#F5F5F5"
> +    color: UbuntuColors.Porcelain

This should be "UbuntuColors.porcelain" (the 'p' is lower case).

>      width: expanded ? (collapsed ? units.gu(8) : units.gu(22)) : 0
>  
>      property bool collapsed: collapsedSidebar


-- 
https://code.launchpad.net/~popey/ubuntu-filemanager-app/fix-1554621/+merge/291133
Your team Ubuntu File Manager Developers is requested to review the proposed merge of lp:~popey/ubuntu-filemanager-app/fix-1554621 into lp:ubuntu-filemanager-app.