← Back to team overview

ubuntu-touch-coreapps-reviewers team mailing list archive

[Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-1545142 into lp:ubuntu-docviewer-app

 

Stefano Verzegnassi has proposed merging lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-1545142 into lp:ubuntu-docviewer-app.

Commit message:
PdfViewer - Presentation mode: use a single-tap gesture (instead of double tap) to show/hide header

Requested reviews:
  Ubuntu Document Viewer Developers (ubuntu-docviewer-dev)
Related bugs:
  Bug #1545142 in Ubuntu Document Viewer App: "Hard to guess how to close 'presentation mode'"
  https://bugs.launchpad.net/ubuntu-docviewer-app/+bug/1545142

For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/fix-1545142/+merge/291293

PdfViewer - Presentation mode: use a single-tap gesture (instead of double tap) to show/hide header
-- 
Your team Ubuntu Document Viewer Developers is requested to review the proposed merge of lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-1545142 into lp:ubuntu-docviewer-app.
=== modified file 'src/app/qml/pdfView/PdfPresentation.qml'
--- src/app/qml/pdfView/PdfPresentation.qml	2016-03-26 18:44:53 +0000
+++ src/app/qml/pdfView/PdfPresentation.qml	2016-04-07 18:11:47 +0000
@@ -85,7 +85,7 @@
 
         MouseArea {
             anchors.fill: parent
-            onDoubleClicked: pdfPage.header.visible = !pdfPage.header.visible
+            onClicked: pdfPage.header.visible = !pdfPage.header.visible
 
             // Hide mouse curson when there's no on-going mouse event
             hoverEnabled: true


Follow ups