ubuntu-touch-coreapps-reviewers team mailing list archive

[Renato Araujo Oliveira Filho <renato.filho@xxxxxxxxxxxxx>]

Renato Araujo Oliveira Filho has proposed merging lp:~renatofilho/ubuntu-calendar-app/destroy-bottom-edge-page into lp:ubuntu-calendar-app.

Commit message:
Make sure that bottom edge page is destroyed after collapse it.

Requested reviews:
  Jenkins Bot (ubuntu-core-apps-jenkins-bot): continuous-integration
  Ubuntu Calendar Developers (ubuntu-calendar-dev)

For more details, see:
https://code.launchpad.net/~renatofilho/ubuntu-calendar-app/destroy-bottom-edge-page/+merge/291824
-- 
Your team Ubuntu Calendar Developers is requested to review the proposed merge of lp:~renatofilho/ubuntu-calendar-app/destroy-bottom-edge-page into lp:ubuntu-calendar-app.

=== modified file 'NewEventBottomEdge.qml'
--- NewEventBottomEdge.qml	2016-03-18 00:40:37 +0000
+++ NewEventBottomEdge.qml	2016-04-13 21:24:53 +0000
@@ -63,13 +63,6 @@
         implicitWidth: bottomEdge.width
         implicitHeight: bottomEdge.height
         children: bottomEdge._realPage
-        Component.onDestruction: {
-            if (bottomEdge._realPage) {
-                bottomEdge._realPage.destroy()
-                bottomEdge._realPage = null
-                _realPage = editorPageBottomEdge.createObject(null)
-            }
-        }
     }
 
     onCommitStarted: {
@@ -77,6 +70,14 @@
         updateNewEventInfo(bottomEdge.date ? bottomEdge.date : new Date(), false)
     }
 
+    onCollapseCompleted: {
+        if (bottomEdge._realPage) {
+            bottomEdge._realPage.destroy()
+            bottomEdge._realPage = null
+            _realPage = editorPageBottomEdge.createObject(null)
+        }
+    }
+
     Component.onCompleted:  {
         if (eventModel)
             _realPage = editorPageBottomEdge.createObject(null)