ubuntu-touch-coreapps-reviewers team mailing list archive

[Arthur Mello <arthur.mello@xxxxxxxxxxxxx>]

Diff comments:

> 
> === modified file 'calendar_canvas.js'
> --- calendar_canvas.js	2016-04-05 14:44:37 +0000
> +++ calendar_canvas.js	2016-04-27 20:03:38 +0000
> @@ -3,6 +3,11 @@
>  
>  function minutesSince(since, until)
>  {
> +    if (isNaN(until.getTime())) {

Does it worth to do the same check for since?

> +        console.debug("Invalid until time:" + until)
> +        return 0
> +    }
> +
>      var sinceTime = new Date(since)
>      sinceTime.setSeconds(0)
>      var untilTime =  new Date(until)


-- 
https://code.launchpad.net/~renatofilho/ubuntu-calendar-app/handle-events-with-invalid-date/+merge/293169
Your team Ubuntu Calendar Developers is requested to review the proposed merge of lp:~renatofilho/ubuntu-calendar-app/handle-events-with-invalid-date into lp:ubuntu-calendar-app.