ubuntu-touch-coreapps-reviewers team mailing list archive

[Michael Zanetti <michael.zanetti@xxxxxxxxxxxxx>]

Michael Zanetti has proposed merging lp:~mzanetti/reminders-app/section-separator into lp:reminders-app.

Commit message:
Add a separator to section headers

Requested reviews:
  Ubuntu Notes app developers (notes-app-dev)

For more details, see:
https://code.launchpad.net/~mzanetti/reminders-app/section-separator/+merge/293622
-- 
Your team Ubuntu Notes app developers is requested to review the proposed merge of lp:~mzanetti/reminders-app/section-separator into lp:reminders-app.

=== modified file 'src/app/qml/ui/NotesPage.qml'
--- src/app/qml/ui/NotesPage.qml	2016-04-30 21:32:48 +0000
+++ src/app/qml/ui/NotesPage.qml	2016-05-03 13:27:25 +0000
@@ -215,9 +215,15 @@
         }
         section.property: root.sortOrderToString(notes.sortOrder);
 
-        section.delegate: Empty {
+        section.delegate: ListItem {
             height: units.gu(5)
-            showDivider: false
+            Rectangle {
+                anchors { left: parent.left; top: parent.top; right: parent.right }
+                height: units.dp(1)
+                color: theme.palette.normal.base
+                visible: index > 0
+            }
+
             RowLayout {
                 anchors { left: parent.left; right: parent.right; verticalCenter: parent.verticalCenter; margins: units.gu(1) }
                 Label {