ubuntu-touch-coreapps-reviewers team mailing list archive

[Stefano Verzegnassi <stefano92.100@xxxxxxxxx>]

Stefano Verzegnassi has proposed merging lp:~verzegnassi-stefano/ubuntu-docviewer-app/content-hub-dont-load-async into lp:ubuntu-docviewer-app.

Commit message:
Do not initialize content-hub asynchronously, otherwise a transfer can not be finalized if the app is not already launched.
This bug likely exists since months, but after the recent changes in content-hub it seems easier to trigger.

Requested reviews:
  Jenkins Bot (ubuntu-core-apps-jenkins-bot): continuous-integration
  Ubuntu Document Viewer Developers (ubuntu-docviewer-dev)

For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/content-hub-dont-load-async/+merge/294122

Do not initialize content-hub asynchronously, otherwise a transfer can not be finalized if the app is not already launched.
This bug likely exists since months, but after the recent changes in content-hub it seems easier to trigger.
-- 
Your team Ubuntu Document Viewer Developers is requested to review the proposed merge of lp:~verzegnassi-stefano/ubuntu-docviewer-app/content-hub-dont-load-async into lp:ubuntu-docviewer-app.

=== modified file 'src/app/qml/ubuntu-docviewer-app.qml'
--- src/app/qml/ubuntu-docviewer-app.qml	2016-04-05 09:33:28 +0000
+++ src/app/qml/ubuntu-docviewer-app.qml	2016-05-09 12:25:35 +0000
@@ -207,7 +207,6 @@
     // Content Hub support
     Loader {
         id: contentHubLoader
-        asynchronous: true
         source: Qt.resolvedUrl("common/ContentHubProxy.qml")
     }