ubuntu-touch-coreapps-reviewers team mailing list archive

[Andrew Hayzen <ahayzen@xxxxxxxxx>]

Andrew Hayzen has proposed merging lp:~ahayzen/ubuntu-weather-app/fix-1602691-osm-geocode-needs-useragent into lp:ubuntu-weather-app.

Commit message:
* Set useragent in geocode so that osm can uniquely identify our requests

Requested reviews:
  Ubuntu Weather Developers (ubuntu-weather-dev)
Related bugs:
  Bug #1602691 in Ubuntu Weather App: "No location in weather app on latest images"
  https://bugs.launchpad.net/ubuntu-weather-app/+bug/1602691

For more details, see:
https://code.launchpad.net/~ahayzen/ubuntu-weather-app/fix-1602691-osm-geocode-needs-useragent/+merge/300452

* Set useragent in geocode so that osm can uniquely identify our requests

This fixes the issue of location not being detected within the weather-app.
-- 
Your team Ubuntu Weather Developers is requested to review the proposed merge of lp:~ahayzen/ubuntu-weather-app/fix-1602691-osm-geocode-needs-useragent into lp:ubuntu-weather-app.

=== modified file 'app/components/CurrentLocation.qml'
--- app/components/CurrentLocation.qml	2015-11-02 21:28:34 +0000
+++ app/components/CurrentLocation.qml	2016-07-19 11:33:24 +0000
@@ -65,6 +65,12 @@
     Plugin {
         id: osmPlugin
         name: "osm"
+
+        // Set a useragent so that osm can uniquely identify out requests
+        PluginParameter {
+            name: "osm.useragent"
+            value: "ubuntu-weather-app"
+        }
     }
 
     GeocodeModel {

=== modified file 'debian/changelog'
--- debian/changelog	2016-06-05 20:16:22 +0000
+++ debian/changelog	2016-07-19 11:33:24 +0000
@@ -1,4 +1,12 @@
-ubuntu-weather-app (3.3ubuntu1) UNRELEASED; urgency=medium
+ubuntu-weather-app (3.4ubuntu1) UNRELEASED; urgency=medium
+
+  [ Andrew Hayzen ]
+  * Set useragent in geocode so that osm can uniquely identify our requests
+  * Release 3.3 and bump version to 3.4
+
+ -- Andrew Hayzen <ahayzen@xxxxxxxxx>  Tue, 19 Jul 2016 12:22:57 +0100
+
+ubuntu-weather-app (3.3ubuntu1) xenial; urgency=medium
 
   [ Andrew Hayzen ]
   * Release 3.2 and bump version to 3.3
@@ -8,7 +16,7 @@
   * Update to use new weather API
   * Change the trimAPIKey function so it only trims the API Key
 
- -- Andrew Hayzen <ahayzen@xxxxxxxxx>  Sat, 04 Jun 2016 18:31:29 +0100
+ -- Andrew Hayzen <ahayzen@xxxxxxxxx>  Tue, 19 Jul 2016 12:22:35 +0100
 
 ubuntu-weather-app (3.2ubuntu1) vivid; urgency=medium
 

=== modified file 'manifest.json.in'
--- manifest.json.in	2016-06-05 20:16:22 +0000
+++ manifest.json.in	2016-07-19 11:33:24 +0000
@@ -12,7 +12,7 @@
     "maintainer": "Ubuntu App Cats <ubuntu-touch-coreapps@xxxxxxxxxxxxxxxxxxx>",
     "name": "@PROJECT_NAME@",
     "title": "Weather",
-    "version": "3.3.@BZR_REVNO@",
+    "version": "3.4.@BZR_REVNO@",
     "x-source": {
         "vcs-bzr": "@BZR_SOURCE@",
         "vcs-bzr-revno": "@BZR_REVNO@"