ubuntu-touch-coreapps-reviewers team mailing list archive

[Arthur Mello <arthur.mello@xxxxxxxxxxxxx>]

Arthur Mello has proposed merging lp:~artmello/ubuntu-calendar-app/ubuntu-calendar-app-fix_1612108 into lp:ubuntu-calendar-app.

Commit message:
Set VisualReminder message field to be equal event title

Requested reviews:
  Jenkins Bot (ubuntu-core-apps-jenkins-bot): continuous-integration
  Ubuntu Calendar Developers (ubuntu-calendar-dev)
Related bugs:
  Bug #1612108 in Ubuntu Calendar App: "No notifications when calendar event occurs"
  https://bugs.launchpad.net/ubuntu-calendar-app/+bug/1612108
  Bug #1621355 in Ubuntu Calendar App: "Event reminder doesn't triggered 5 min befor the event."
  https://bugs.launchpad.net/ubuntu-calendar-app/+bug/1621355

For more details, see:
https://code.launchpad.net/~artmello/ubuntu-calendar-app/ubuntu-calendar-app-fix_1612108/+merge/305533

Set VisualReminder message field to be equal event title
-- 
Your team Ubuntu Calendar Developers is requested to review the proposed merge of lp:~artmello/ubuntu-calendar-app/ubuntu-calendar-app-fix_1612108 into lp:ubuntu-calendar-app.

=== modified file 'NewEvent.qml'
--- NewEvent.qml	2016-08-26 19:25:14 +0000
+++ NewEvent.qml	2016-09-12 21:00:01 +0000
@@ -295,6 +295,7 @@
                     reminder.repetitionCount = 0
                     reminder.repetitionDelay = 0
                 }
+		reminder.message = titleEdit.text
                 reminder.secondsBeforeStart = root.reminderValue
                 event.setDetail(reminder)
             } else if (reminder) {