ubuntu-touch-coreapps-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~popey/ubuntu-terminal-app/add-snapcraft-config into lp:ubuntu-terminal-app

To: Alan Pope 🍺🐧🐱 <alan@xxxxxxxxxx>
From: David Planella <david.planella@xxxxxxxxxx>
Date: Thu, 15 Sep 2016 10:35:22 -0000
In-reply-to: <20160908114436.21619.76562.launchpad@ackee.canonical.com>
Reply-to: mp+305206@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

Looks good to me, thanks!

I think we can merge it as it is. CLICK_MODE=on is not necessary and installs extra files [1], but it seems the snap works, so we might as well leave it as it is for a first pass.

[1] http://bazaar.launchpad.net/~ubuntu-terminal-dev/ubuntu-terminal-app/reboot/view/head:/CMakeLists.txt#L24
-- 
https://code.launchpad.net/~popey/ubuntu-terminal-app/add-snapcraft-config/+merge/305206
Your team Ubuntu Terminal Developers is subscribed to branch lp:ubuntu-terminal-app.

References

[Merge] lp:~popey/ubuntu-terminal-app/add-snapcraft-config into lp:ubuntu-terminal-app
From: Alan Pope , 2016-09-08