ubuntu-touch-coreapps-reviewers team mailing list archive

[Iain Lane <iain@xxxxxxxxxxxxxxxxxxx>]

Iain Lane has proposed merging lp:~laney/ubuntu-terminal-app/notshowin-unity into lp:ubuntu-terminal-app.

Requested reviews:
  Ubuntu Terminal Developers (ubuntu-terminal-dev)

For more details, see:
https://code.launchpad.net/~laney/ubuntu-terminal-app/notshowin-unity/+merge/306855

See https://bugs.launchpad.net/ubuntu/+bug/1626457/comments/1 for the rationale.

We should use OnlyShowIn=Unity8, but that is blocked by various bugs, see https://trello.com/c/RI6eK4OA/106-duplicate-terminal-applications-in-unity-7-session-fix-xdg-current-desktop-and-onlyshowin-handling
-- 
Your team Ubuntu Terminal Developers is requested to review the proposed merge of lp:~laney/ubuntu-terminal-app/notshowin-unity into lp:ubuntu-terminal-app.

=== modified file 'com.ubuntu.terminal.desktop.in.in'
--- com.ubuntu.terminal.desktop.in.in	2016-02-11 20:43:44 +0000
+++ com.ubuntu.terminal.desktop.in.in	2016-09-27 10:50:58 +0000
@@ -8,3 +8,4 @@
 X-Ubuntu-Touch=true
 X-Ubuntu-Default-Department-ID=accessories
 X-Ubuntu-Splash-Color=#111111
+NotShowIn=Unity7

=== modified file 'debian/changelog'
--- debian/changelog	2016-09-19 00:44:11 +0000
+++ debian/changelog	2016-09-27 10:50:58 +0000
@@ -1,5 +1,6 @@
 ubuntu-terminal-app (0.7ubuntu1) UNRELEASED; urgency=medium
 
+  [ Luke Yelavich ]
   * Get packaging ready for inclusion in yakkety (LP: #1623845)
   * Update standards version
   * Fix up build dependency formatting
@@ -7,6 +8,11 @@
   * Update copyright
   * Update Vcs-bzr field
 
+  [ Iain Lane ]
+  * com.ubuntu.terminal.desktop.in.in: Add NotShowIn=Unity7 - we have
+    gnome-terminal there, and having two applications called "Terminal" will
+    be confusing.
+
  -- Luke Yelavich <themuso@xxxxxxxxxx>  Fri, 16 Sep 2016 09:04:28 +1000
 
 ubuntu-terminal-app (0.7) wily; urgency=medium