ubuntu-touch-coreapps-reviewers team mailing list archive

[Renato Araujo Oliveira Filho <renato.filho@xxxxxxxxxxxxx>]

Renato Araujo Oliveira Filho has proposed merging lp:~renatofilho/ubuntu-docviewer-app/ubunut-app-platform into lp:ubuntu-docviewer-app.

Commit message:
Create snapcract package.

Requested reviews:
  Ubuntu Document Viewer Developers (ubuntu-docviewer-dev)

For more details, see:
https://code.launchpad.net/~renatofilho/ubuntu-docviewer-app/ubunut-app-platform/+merge/312913
-- 
Your team Ubuntu Document Viewer Developers is requested to review the proposed merge of lp:~renatofilho/ubuntu-docviewer-app/ubunut-app-platform into lp:ubuntu-docviewer-app.

=== added directory 'snap'
=== added directory 'snap/ubuntu-app-platform'
=== added file 'snapcraft.yaml'
--- snapcraft.yaml	1970-01-01 00:00:00 +0000
+++ snapcraft.yaml	2016-12-09 13:24:41 +0000
@@ -0,0 +1,75 @@
+name: ubuntu-docviewer-app
+version: 2.1.350
+summary: Document Viewer
+description: Document Viewer application for Ubuntu devices
+confinement: strict
+grade: devel
+
+apps:
+    ubuntu-docviewer-app:
+        command: desktop-launch $SNAP/usr/bin/ubuntu-docviewer-app ---documentsDir=$(HOME=/home/$USER xdg-user-dir DOCUMENTS) -desktop_file_hint=unity8 "$@"
+        plugs:
+            - home
+            - opengl
+            - platform
+            - unity7
+            - unity8
+
+plugs:
+    platform:
+        interface: content
+        content: ubuntu-app-platform1
+        target: ubuntu-app-platform
+        default-provider: ubuntu-app-platform
+
+parts:
+    ubuntu-docviewer-app:
+        plugin: cmake
+        configflags: [-DCMAKE_INSTALL_PREFIX=/usr, -DCLICK_MODE=off]
+        source: .
+        build-packages:
+            - cmake
+            - intltool
+            - libpoppler-qt5-dev
+            - qtbase5-private-dev
+            - qtdeclarative5-private-dev
+            - qtdeclarative5-qtquick2-plugin
+        stage-packages:
+            - qtdeclarative5-poppler1.0
+            - xdg-user-dirs
+        snap:
+            # ubuntu-docviewer-app
+            - usr/bin/ubuntu-docviewer-app
+            - usr/share/applications
+            - usr/share/locale
+            - usr/share/ubuntu-docviewer-app
+
+            # qtdeclarative5-documentviewer-common
+            - usr/lib/*/qt5/qml/DocumentViewer/qmldir
+            - usr/lib/*/qt5/qml/DocumentViewer/libfileqmlplugin.so
+
+            # qtdeclarative5-documentviewer-libreoffice
+            - usr/lib/*/qt5/qml/DocumentViewer/LibreOffice
+
+            # qtdeclarative5-documentviewer-pdf
+            - usr/lib/*/qt5/qml/DocumentViewer/PDF
+
+            # qtdeclarative5-poppler1.0
+            - usr/lib/*/qt5/qml/org/docviewer
+            - usr/share/doc/qtdeclarative5-poppler1.0/copyright
+
+            # xdg-user-dirs
+            - usr/share/locale/*/LC_MESSAGES/xdg-user-dirs.mo
+            - usr/bin/xdg-user-dir
+            - usr/bin/xdg-user-dirs-update
+            - etc/xdg/user-dirs.conf
+            - etc/xdg/user-dirs.defaults
+            - etc/X11/Xsession.d/60xdg-user-dirs-update
+            - usr/share/doc/xdg-user-dirs/copyright
+            - usr/share/doc/xdg-user-dirs/AUTHORS
+
+    platform:
+        plugin: dump
+        source: snap
+        after: [desktop-ubuntu-app-platform]
+        snap: [ubuntu-app-platform]

=== modified file 'src/app/config.h.in'
--- src/app/config.h.in	2015-10-20 11:58:48 +0000
+++ src/app/config.h.in	2016-12-09 13:24:41 +0000
@@ -21,6 +21,8 @@
 #include <QtCore/QDir>
 #include <QtCore/QString>
 
+static QString SNAP_ENV = qgetenv("SNAP");
+
 inline bool isClick() {
     static bool click = (QCoreApplication::applicationDirPath().contains("click.ubuntu.com"));
     return click;
@@ -34,7 +36,9 @@
 
 inline QString docviewerDirectory()
 {
-    if (isClick()) {
+    if (!SNAP_ENV.isEmpty()) {
+        return SNAP_ENV + QString("@CMAKE_INSTALL_PREFIX@/@DATA_DIR@");
+    } else if (isClick()) {
         return QString(".");
     } else if (isRunningInstalled()) {
         return QString("@CMAKE_INSTALL_PREFIX@/@DATA_DIR@");