ubuntu-touch-coreapps-reviewers team mailing list archive

[Andrew Hayzen <andrew.hayzen@xxxxxxxxxxxxx>]

Andrew Hayzen has proposed merging lp:~ahayzen/ubuntu-weather-app/finish-snapcraft-implementation-001 into lp:ubuntu-weather-app.

Commit message:
* Add correct plugs to work when confined
* Correct path for icon in desktop file

Requested reviews:
  Ubuntu Weather Developers (ubuntu-weather-dev)

For more details, see:
https://code.launchpad.net/~ahayzen/ubuntu-weather-app/finish-snapcraft-implementation-001/+merge/313490

* Add correct plugs to work when confined
* Correct path for icon in desktop file

Note that you have to inject the API keys into the app/data/keys.js before running snapcraft.
-- 
Your team Ubuntu Weather Developers is requested to review the proposed merge of lp:~ahayzen/ubuntu-weather-app/finish-snapcraft-implementation-001 into lp:ubuntu-weather-app.

=== modified file 'setup/gui/ubuntu-weather-app.desktop'
--- setup/gui/ubuntu-weather-app.desktop	2016-11-24 10:59:52 +0000
+++ setup/gui/ubuntu-weather-app.desktop	2016-12-17 15:39:08 +0000
@@ -3,7 +3,7 @@
 Type=Application
 Terminal=false
 Exec=ubuntu-weather-app %u
-Icon=/snap/ubuntu-weather-app/current/meta/gui/icon.png
+Icon=${SNAP}/meta/gui/icon.png
 Name=Weather
 Name[aa]=Deesaasa
 Name[am]=የ አየር ንብረት

=== modified file 'snapcraft.yaml'
--- snapcraft.yaml	2016-11-24 03:45:31 +0000
+++ snapcraft.yaml	2016-12-17 15:39:08 +0000
@@ -4,13 +4,19 @@
 description: |
     A weather forecast application for Ubuntu with support for multiple online weather data sources.
 grade: devel
-confinement: devmode
+confinement: strict
 architectures: [all]
 
 apps:
     ubuntu-weather-app:
         command: desktop-launch qmlscene --desktop_file_hint=unity8 $SNAP/usr/share/ubuntu-weather-app/app/ubuntu-weather-app.qml 
-        plugs: [unity7, platform, opengl, home, gsettings]
+        plugs:
+            - network
+            - location-observe
+            - opengl
+            - platform
+            - unity7
+            - unity8
 
 plugs:
     platform:
@@ -20,14 +26,15 @@
         default-provider: ubuntu-app-platform
 
 parts:
-  ubuntu-weather-app:
-    plugin: cmake
-    configflags: [-DCMAKE_INSTALL_PREFIX=/usr, -DCLICK_MODE=off]
-    source: .
-    build-packages:
-        - cmake
-        - intltool
-    after: [desktop-ubuntu-app-platform]
-  environment:
-    source: snap/
-    plugin: dump
+    ubuntu-weather-app:
+        plugin: cmake
+        configflags: [-DCMAKE_INSTALL_PREFIX=/usr, -DCLICK_MODE=off]
+        source: .
+        build-packages:
+            - cmake
+            - intltool
+        after: [desktop-ubuntu-app-platform]
+
+    environment:
+        source: snap/
+        plugin: dump