← Back to team overview

ubuntu-touch-coreapps-reviewers team mailing list archive

[Merge] lp:~mterry/ubuntu-terminal-app/mir-interface into lp:ubuntu-terminal-app

 

Michael Terry has proposed merging lp:~mterry/ubuntu-terminal-app/mir-interface into lp:ubuntu-terminal-app.

Commit message:
Add support for connecting to the Mir socket.

Requested reviews:
  Ubuntu Terminal Developers (ubuntu-terminal-dev)

For more details, see:
https://code.launchpad.net/~mterry/ubuntu-terminal-app/mir-interface/+merge/317907

Add support for connecting to the Mir socket.  This way it avoids xmir under unity8.

I didn't bother using the mir-libs content interface yet, since built-in support for that hasn't landed in snapcraft-desktop-helpers yet.

But this alone is good enough to make it work under our current unity8 snap.
-- 
Your team Ubuntu Terminal Developers is requested to review the proposed merge of lp:~mterry/ubuntu-terminal-app/mir-interface into lp:ubuntu-terminal-app.
=== modified file 'snapcraft.yaml'
--- snapcraft.yaml	2017-02-01 14:43:39 +0000
+++ snapcraft.yaml	2017-02-21 20:17:10 +0000
@@ -9,7 +9,7 @@
   ubuntu-terminal-app:
     command: desktop-launch $SNAP/bin/terminal.wrapper
     desktop: usr/share/applications/ubuntu-terminal-app.desktop
-    plugs: [unity7, unity8, opengl, network, network-bind, home, platform]
+    plugs: [unity7, unity8, opengl, network, network-bind, home, platform, mir]
 
 plugs:
   platform:


Follow ups