ubuntu-touch-coreapps-reviewers team mailing list archive

[Florian Boucault <florian.boucault@xxxxxxxxxxxxx>]

Florian Boucault has proposed merging lp:~fboucault/ubuntu-terminal-app/do_not_embed_ui_extras into lp:ubuntu-terminal-app/staging.

Commit message:
Do not embed ubuntu-ui-extras as it is provided by ubuntu-app-platform

Requested reviews:
  Jenkins Bot (ubuntu-core-apps-jenkins-bot): continuous-integration
  Ubuntu Terminal Developers (ubuntu-terminal-dev)

For more details, see:
https://code.launchpad.net/~fboucault/ubuntu-terminal-app/do_not_embed_ui_extras/+merge/318882

Do not embed ubuntu-ui-extras as it is provided by ubuntu-app-platform
-- 
Your team Ubuntu Terminal Developers is requested to review the proposed merge of lp:~fboucault/ubuntu-terminal-app/do_not_embed_ui_extras into lp:ubuntu-terminal-app/staging.

=== modified file 'snapcraft.yaml'
--- snapcraft.yaml	2017-02-21 20:15:02 +0000
+++ snapcraft.yaml	2017-03-03 09:02:27 +0000
@@ -45,18 +45,3 @@
       - fonts-inconsolata
     build-attributes: [no-system-libraries]
     after: [desktop-ubuntu-app-platform]
-
-  ubuntu-ui-extras:
-    plugin: cmake
-    configflags: [-DCMAKE_INSTALL_PREFIX=/usr]
-    source: http://code.launchpad.net/~phablet-team/ubuntu-ui-extras/tabs
-    source-type: bzr
-    build-packages:
-      - gettext
-      - pkg-config
-      - qtbase5-dev
-      - qtdeclarative5-dev
-      - libexiv2-dev
-    stage-packages:
-      - libexiv2-14
-    build-attributes: [no-system-libraries]