ubuntu-touch-coreapps-reviewers team mailing list archive

[Renato Araujo Oliveira Filho <renato.filho@xxxxxxxxxxxxx>]

Renato Araujo Oliveira Filho has proposed merging lp:~renatofilho/ubuntu-weather-app/add-missing-mir into lp:ubuntu-weather-app.

Commit message:
[snap] propagate args to qmlscene and add missing "mir" into the plug list.

Requested reviews:
  Ubuntu Weather Developers (ubuntu-weather-dev)

For more details, see:
https://code.launchpad.net/~renatofilho/ubuntu-weather-app/add-missing-mir/+merge/321696
-- 
Your team Ubuntu Weather Developers is requested to review the proposed merge of lp:~renatofilho/ubuntu-weather-app/add-missing-mir into lp:ubuntu-weather-app.

=== modified file 'snapcraft.yaml'
--- snapcraft.yaml	2017-03-28 19:28:59 +0000
+++ snapcraft.yaml	2017-04-03 15:17:37 +0000
@@ -3,22 +3,14 @@
 summary: ubuntu weather app.
 description: |
     A weather forecast application for Ubuntu with support for multiple online weather data sources.
+confinement: strict
 grade: devel
-confinement: strict
 architectures: [all]
 
 apps:
     ubuntu-weather-app:
-        aliases: [ubuntu-weather-app]
-        command: desktop-launch qmlscene $SNAP/usr/share/ubuntu-weather-app/app/ubuntu-weather-app.qml 
-        plugs:
-            - network
-            - location-observe
-            - opengl
-            - platform
-            - unity7
-            - unity8
-            - mir-libs
+        command: desktop-launch qmlscene "$@" $SNAP/usr/share/ubuntu-weather-app/app/ubuntu-weather-app.qml 
+        plugs: [network, location-observe, opengl, platform, unity7, unity8, mir, mir-libs]
 
 plugs:
     platform: