← Back to team overview

ubuntu-touch-coreapps team mailing list archive

Re: [Terminal] Numerous branches proposed to be merged

 

/me stretches

Back from break, these look great! I'll review if no one else has and get the new version pushed into the store. Thanks Victor!

Still need to figure this bug out though:

https://bugs.launchpad.net/ubuntu-terminal-app/+bug/1257791

Nicholas

On 12/20/2013 11:54 AM, Victor Thompson wrote:
Terminal app developers,

There are a number of branches I have proposed to be merged and would like to have them reviewed if possible. Could someone review them?

* Terminal starts with long unfriendly path. Bug [1] Merge proposal [2]
* Do not use deprecated ValueSelector component. Bug [3] Merge proposal [4]
* Panel button text is unreadable. Bug [5] Merge proposal [6]
* Exit the application if the user types "exit" or the session otherwise ends. Merge proposal [7]

Thanks,

Victor

[1] https://bugs.launchpad.net/ubuntu-terminal-app/+bug/1239089
[2] https://code.launchpad.net/~vthompson/ubuntu-terminal-app/fixes-1239089/+merge/195499 <https://code.launchpad.net/%7Evthompson/ubuntu-terminal-app/fixes-1239089/+merge/195499>
[3] https://bugs.launchpad.net/ubuntu-terminal-app/+bug/1245976
[4] https://code.launchpad.net/~vthompson/ubuntu-terminal-app/fixes-1245976/+merge/193728 <https://code.launchpad.net/%7Evthompson/ubuntu-terminal-app/fixes-1245976/+merge/193728>
[5] https://bugs.launchpad.net/ubuntu-terminal-app/+bug/1260903
[6] https://code.launchpad.net/~vthompson/ubuntu-terminal-app/fixes-1260903-button-text-size-color <https://code.launchpad.net/%7Evthompson/ubuntu-terminal-app/fixes-1260903-button-text-size-color> [7] https://code.launchpad.net/~vthompson/ubuntu-terminal-app/exit-app/+merge/195500 <https://code.launchpad.net/%7Evthompson/ubuntu-terminal-app/exit-app/+merge/195500>




References