← Back to team overview

ubuntu-webapps-bugs team mailing list archive

[Bug 1240682] Re: some js files use tabs, others spaces for indentation

 

** Changed in: ubuntu-html5-theme
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
WebApps bug tracking, which is subscribed to ubuntu-html5-theme in
Ubuntu.
https://bugs.launchpad.net/bugs/1240682

Title:
  some js files use tabs, others spaces for indentation

Status in Ubuntu UI SDK for HTML5 Apps:
  Fix Released
Status in “ubuntu-html5-theme” package in Ubuntu:
  Fix Released

Bug description:
  Not sure if there is an "official" code style guide for this project,
  but the js files are inconsistent, which makes them harder to edit.

  Here's a sample of how lists.js appears now in vim:

      var __addUlIfNotFound = function(list) {
  >.if (list) {
  >.    var uls = list.querySelectorAll('ul');
  >.    if (uls == null || uls.length == 0) {
  >.>.var ul = document.createElement('ul');
  >.>.list.appendChild(ul);
  >.    }   
  >.}

  The ">" chars are tabs.

  Now using four spaces indentation: core.js dialogs.js fast-buttons.js
  popovers.js toolbars.js

  Now Using Tab indentation: list.js. pagestack.js button.js

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-html5-theme/+bug/1240682/+subscriptions