ubuntu-webapps-bugs team mailing list archive
-
ubuntu-webapps-bugs team
-
Mailing list archive
-
Message #01992
[Bug 1399330] Re: Stop disabling external schemes via QDesktopServices in tests
** Changed in: oxide
Status: Triaged => Fix Released
** Changed in: oxide
Milestone: None => branch-1.5
** Changed in: oxide
Assignee: (unassigned) => Chris Coulson (chrisccoulson)
--
You received this bug notification because you are a member of Ubuntu
WebApps bug tracking, which is subscribed to Oxide.
https://bugs.launchpad.net/bugs/1399330
Title:
Stop disabling external schemes via QDesktopServices in tests
Status in Oxide Webview:
Fix Released
Bug description:
Some tests use a bogus protocol to trigger an error condition (ie,
failed load). Since bug 1384460 landed, these bogus protocols get
handed off to QDesktopServices which results in the load being
cancelled. To work around this, there is a test API to tell
QDesktopServices to not handle the bogus protocol, restoring the old
behaviour (load failing).
Rather than doing this we should adapt the tests to accept the updated
beahviour (which I assume is that we get a stopped load rather than a
failed load), as this is closer to the real-world behaviour. Tests
that need a failed load should create it another way (eg, using an
invalid http URL)
To manage notifications about this bug go to:
https://bugs.launchpad.net/oxide/+bug/1399330/+subscriptions
References