ubuntu-webapps-bugs team mailing list archive

[Chris Coulson <chris.coulson@xxxxxxxxxxxxx>]

Public bug reported:

Bug 1453294 converted OxideQSslCertificate to a value type. As a
consequence, where OxideQSecurityStatus::certificate() and
OxideQSslCertificate::issuer() used to return nullptr  they now return a
value where OxideQSslCertificate::isValid() returns false.

This has a couple of issues:
- It's a slight change in API behaviour. Any applications that are walking the issuer chain and checking for null to detect the top of the chain will now end up in an infinite loop.
- It's weird from QML to have to check SslCertificate.isValid rather than null.

It might be appropriate instead to have these accessors return
QVariants. This will allow us to keep OxideQSslCertificate as a value
type whilst being able to represent a null certificate.

** Affects: oxide
     Importance: High
     Assignee: Chris Coulson (chrisccoulson)
         Status: Triaged

** Affects: oxide/1.9
     Importance: High
     Assignee: Chris Coulson (chrisccoulson)
         Status: Triaged

** Changed in: oxide
   Importance: Undecided => High

** Changed in: oxide
       Status: New => Triaged

** Changed in: oxide
    Milestone: None => branch-1.10

** Also affects: oxide/1.9
   Importance: Undecided
       Status: New

** Changed in: oxide/1.9
   Importance: Undecided => High

** Changed in: oxide/1.9
       Status: New => Triaged

** Changed in: oxide
     Assignee: (unassigned) => Chris Coulson (chrisccoulson)

** Changed in: oxide/1.9
     Assignee: (unassigned) => Chris Coulson (chrisccoulson)

-- 
You received this bug notification because you are a member of Ubuntu
WebApps bug tracking, which is subscribed to Oxide.
https://bugs.launchpad.net/bugs/1479038

Title:
  Change OxideQSecurityStatus::certificate() and
  OxideQSslCertificate::issuer() to return a QVariant

Status in Oxide:
  Triaged
Status in Oxide 1.9 series:
  Triaged

Bug description:
  Bug 1453294 converted OxideQSslCertificate to a value type. As a
  consequence, where OxideQSecurityStatus::certificate() and
  OxideQSslCertificate::issuer() used to return nullptr  they now return
  a value where OxideQSslCertificate::isValid() returns false.

  This has a couple of issues:
  - It's a slight change in API behaviour. Any applications that are walking the issuer chain and checking for null to detect the top of the chain will now end up in an infinite loop.
  - It's weird from QML to have to check SslCertificate.isValid rather than null.

  It might be appropriate instead to have these accessors return
  QVariants. This will allow us to keep OxideQSslCertificate as a value
  type whilst being able to represent a null certificate.

To manage notifications about this bug go to:
https://bugs.launchpad.net/oxide/+bug/1479038/+subscriptions