ubuntu-webapps-bugs team mailing list archive

[Chris Coulson <chris.coulson@xxxxxxxxxxxxx>]

Public bug reported:

We have some hacky code to expose certain objects on the renderer side
to V8 (ScriptMessage, ScriptMessageRequest etc), but we should get rid
of this and migrate to using gin bindings instead. See
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-
dev/JwSMYicKECQ.

It looks like we just need C++ objects to inherit from gin::Wrappable,
and they should implement GetObjectTemplateBuilder(). gin::Handle can be
used to retain a gin::Wrappable on the stack, but it doesn't look like
gin provides a way to retain one from the heap. We could probably do
this easily enough by providing a helper class which takes a
gin::Wrappable and holds its wrapper in a v8::Persistent

** Affects: oxide
     Importance: Medium
     Assignee: Chris Coulson (chrisccoulson)
         Status: Triaged

** Changed in: oxide
   Importance: Undecided => High

** Changed in: oxide
   Importance: High => Medium

** Changed in: oxide
       Status: New => Triaged

** Changed in: oxide
     Assignee: (unassigned) => Chris Coulson (chrisccoulson)

-- 
You received this bug notification because you are a member of Ubuntu
WebApps bug tracking, which is subscribed to Oxide.
https://bugs.launchpad.net/bugs/1496524

Title:
  Migrate to using gin bindings

Status in Oxide:
  Triaged

Bug description:
  We have some hacky code to expose certain objects on the renderer side
  to V8 (ScriptMessage, ScriptMessageRequest etc), but we should get rid
  of this and migrate to using gin bindings instead. See
  https://groups.google.com/a/chromium.org/forum/#!topic/chromium-
  dev/JwSMYicKECQ.

  It looks like we just need C++ objects to inherit from gin::Wrappable,
  and they should implement GetObjectTemplateBuilder(). gin::Handle can
  be used to retain a gin::Wrappable on the stack, but it doesn't look
  like gin provides a way to retain one from the heap. We could probably
  do this easily enough by providing a helper class which takes a
  gin::Wrappable and holds its wrapper in a v8::Persistent

To manage notifications about this bug go to:
https://bugs.launchpad.net/oxide/+bug/1496524/+subscriptions