ubuntu-webapps-bugs team mailing list archive

[Chris Coulson <chris.coulson@xxxxxxxxxxxxx>]

Public bug reported:

With the implementation for bug 1470268, I'm seeing some test failures
where NavigationRequest.userGesture is false (when it should be true).

The issue is that some renderer-initiated non-CURRENT_TAB navigations
are handled via WebView::OpenURLFromTab (instead of the
WebContentsImpl::CreateNewWindow path that window.open() calls are
handled via), and we lose the content::OpenURLParams::user_gesture value
when converting it to a CURRENT_TAB navigation (when the embedder
doesn't support creating new views) and initiating the load via
NavigationController::LoadURLWithParams.

** Affects: oxide
     Importance: Low
         Status: Triaged

** Changed in: oxide
   Importance: Undecided => Low

** Changed in: oxide
       Status: New => Triaged

-- 
You received this bug notification because you are a member of Ubuntu
WebApps bug tracking, which is subscribed to Oxide.
https://bugs.launchpad.net/bugs/1499434

Title:
  NavigationRequest.userGesture is wrong in some cases after bug 1470268

Status in Oxide:
  Triaged

Bug description:
  With the implementation for bug 1470268, I'm seeing some test failures
  where NavigationRequest.userGesture is false (when it should be true).

  The issue is that some renderer-initiated non-CURRENT_TAB navigations
  are handled via WebView::OpenURLFromTab (instead of the
  WebContentsImpl::CreateNewWindow path that window.open() calls are
  handled via), and we lose the content::OpenURLParams::user_gesture
  value when converting it to a CURRENT_TAB navigation (when the
  embedder doesn't support creating new views) and initiating the load
  via NavigationController::LoadURLWithParams.

To manage notifications about this bug go to:
https://bugs.launchpad.net/oxide/+bug/1499434/+subscriptions