← Back to team overview

ubuntu-webapps-bugs team mailing list archive

[Bug 1623705] [NEW] OxideQQuickWebView is not C++ friendly

 

Public bug reported:

The permission request signals pass the request wrapped in a QJSValue,
which relies on the webview being exposed to the QML engine. This was
done as a way to transfer and share ownership of the request instance
across multiple slots.

Essentially, this is working around the fact that the signal/slot
mechanism is not a good fit for cases like this where we want to
transfer ownership of an object to a single consumer in the application
or ask the application something (they're good for notifying the
application of things).

This should be done instead via a client interface. There could be a
QML-only implementation of the client interface that does use signals so
that the QML API is still nice to use.

** Affects: oxide
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Ubuntu
WebApps bug tracking, which is subscribed to Oxide.
https://bugs.launchpad.net/bugs/1623705

Title:
  OxideQQuickWebView is not C++ friendly

Status in Oxide:
  New

Bug description:
  The permission request signals pass the request wrapped in a QJSValue,
  which relies on the webview being exposed to the QML engine. This was
  done as a way to transfer and share ownership of the request instance
  across multiple slots.

  Essentially, this is working around the fact that the signal/slot
  mechanism is not a good fit for cases like this where we want to
  transfer ownership of an object to a single consumer in the
  application or ask the application something (they're good for
  notifying the application of things).

  This should be done instead via a client interface. There could be a
  QML-only implementation of the client interface that does use signals
  so that the QML API is still nice to use.

To manage notifications about this bug go to:
https://bugs.launchpad.net/oxide/+bug/1623705/+subscriptions