ubuntu-webapps-bugs team mailing list archive

[Chris Coulson <chrisccoulson@xxxxxxxxxx>]

Public bug reported:

The UbuntuWebView context menu "Open <x> in new tab/window" actions will
go through this function, but it has a couple of issues:

- It DCHECK's that OpenURLParams::is_renderer_initiated is true.

- It shouldn't call WebContentsClient::ShouldCreateNewWebContents() for
context menu initiated calls. We don't want the application to block
these (it should create a new tab / window unconditionally)

** Affects: oxide
     Importance: High
     Assignee: Chris Coulson (chrisccoulson)
         Status: Triaged

** Changed in: oxide
   Importance: Undecided => High

** Changed in: oxide
       Status: New => Triaged

** Changed in: oxide
    Milestone: None => branch-1.20

** Changed in: oxide
     Assignee: (unassigned) => Chris Coulson (chrisccoulson)

** Description changed:

  The UbuntuWebView context menu "Open <x> in new tab/window" actions will
  go through this function, but it has a couple of issues:
  
  - It DCHECK's that OpenURLParams::is_renderer_initiated is true.
  
  - It shouldn't call WebContentsClient::ShouldCreateNewWebContents() for
- context menu initiated calls.
+ context menu initiated calls. We don't want the application to block
+ these (it should create a new tab / window unconditionally)

-- 
You received this bug notification because you are a member of Ubuntu
WebApps bug tracking, which is subscribed to Oxide.
https://bugs.launchpad.net/bugs/1640634

Title:
  Update WebView::OpenURLFromTab for context menu interaction

Status in Oxide:
  Triaged

Bug description:
  The UbuntuWebView context menu "Open <x> in new tab/window" actions
  will go through this function, but it has a couple of issues:

  - It DCHECK's that OpenURLParams::is_renderer_initiated is true.

  - It shouldn't call WebContentsClient::ShouldCreateNewWebContents()
  for context menu initiated calls. We don't want the application to
  block these (it should create a new tab / window unconditionally)

To manage notifications about this bug go to:
https://bugs.launchpad.net/oxide/+bug/1640634/+subscriptions